chore: missing rule source by Netail · Pull Request #9871 · biomejs/biome

Netail · 2026-04-08T19:49:35Z

Summary

Added another rule source

As it's inspired, it will not include an eslint migration path, so mainly just docs and thus no changeset needed

Test Plan

Docs

changeset-bot · 2026-04-08T19:49:40Z

⚠️ No Changeset found

Latest commit: 0ac078d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-04-08T19:55:15Z

Walkthrough

Added a new enum variant RuleSource::EslintTypescriptSortKeys(&'a str) and wired it into RuleSource methods: Display, as_rule_name, namespace, and to_rule_url now handle the new variant. The ESLint-to-Biome mapping (TryFrom<&EslintRuleName> for RuleSource<'a>) recognises the typescript-sort-keys source. The UseSortedInterfaceMembers rule metadata now includes RuleSource::EslintTypescriptSortKeys("interface").inspired() alongside the existing Perfectionist source.

Possibly related PRs

#9547: Modifies the same RuleSource<'a> enum and updates rule source metadata by adding eslint-plugin variants and related method adjustments.

Suggested reviewers

dyc3
ematipico

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: missing rule source' directly relates to the changeset, which adds a new RuleSource variant for TypeScript-sort-keys support across multiple files.
Description check	✅ Passed	The description accurately describes the change as adding another rule source that is inspired (without ESLint migration) and notes it is documentation-focused with no changeset needed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/missing-rule-source

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/biome_analyze/src/rule.rs`:
- Around line 195-196: Add the missing match arm for the new enum variant so
migrations recognize the typescript-sort-keys plugin: in the match statement
that maps ESLint plugin names to RuleSource inside migrate/eslint_to_biome.rs,
add a branch for the string "typescript-sort-keys" that returns
RuleSource::EslintTypescriptSortKeys (the enum variant EslintTypescriptSortKeys
defined in rule.rs) so the new variant is reachable during migration.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bf28e7ce-2471-4f8b-a640-3026e4cd83e3

📥 Commits

Reviewing files that changed from the base of the PR and between e8cad58 and 693e572.

📒 Files selected for processing (2)

crates/biome_analyze/src/rule.rs
crates/biome_js_analyze/src/assist/source/use_sorted_interface_members.rs

codspeed-hq · 2026-04-08T19:59:58Z

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 196 skipped benchmarks¹

_{Comparing chore/missing-rule-source (0ac078d) with main (e8cad58)}

196 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/biome_cli/src/execute/migrate/eslint_to_biome.rs`:
- Line 405: Add a migration snapshot test that asserts the new mapping for
"typescript-sort-keys" resolves to RuleSource::EslintTypescriptSortKeys; locate
the existing migration snapshot test suite for the eslint_to_biome migration
(look for tests that use the migration runner or snapshot helpers) and add a
case that imports a rule path like "typescript-sort-keys/<rule>" and captures
the resulting resolved mapping, then add the expected snapshot (or update the
snapshot generator) so CI will verify that typescript-sort-keys routes through
the new branch.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2207f06c-2f12-42dd-a224-c879e2b6ae13

📥 Commits

Reviewing files that changed from the base of the PR and between 693e572 and 0ac078d.

📒 Files selected for processing (3)

crates/biome_analyze/src/rule.rs
crates/biome_cli/src/execute/migrate/eslint_to_biome.rs
crates/biome_js_analyze/src/assist/source/use_sorted_interface_members.rs

✅ Files skipped from review due to trivial changes (2)

crates/biome_js_analyze/src/assist/source/use_sorted_interface_members.rs
crates/biome_analyze/src/rule.rs

coderabbitai · 2026-04-08T20:12:35Z

            Some("vue") => RuleSource::EslintVueJs,
            Some("turbo") => RuleSource::EslintTurbo,
            Some("@html-eslint") => RuleSource::HtmlEslint,
+            Some("typescript-sort-keys") => RuleSource::EslintTypescriptSortKeys,


⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash # Verify whether a migrator spec already covers `typescript-sort-keys` # Expected: at least one match under migrate_eslint specs or nearby tests. rg -n --iglob '*.{json,jsonc,rs}' 'typescript-sort-keys|EslintTypescriptSortKeys'

Repository: biomejs/biome

Length of output: 1208

🏁 Script executed:

fd -t f . tests/specs/migrate_eslint/ | head -20

Repository: biomejs/biome

Length of output: 171

🏁 Script executed:

rg -t json 'typescript-sort-keys' tests/specs/migrate_eslint/ -l

Repository: biomejs/biome

Length of output: 124

🏁 Script executed:

fd -t f migrate_eslint tests/

Repository: biomejs/biome

Length of output: 150

🏁 Script executed:

fd -t d migrate tests/

Repository: biomejs/biome

Length of output: 150

🏁 Script executed:

git ls-files | grep -i migrate | head -20

Repository: biomejs/biome

Length of output: 1084

🏁 Script executed:

git ls-files | grep -i test | grep -i eslint | head -20

Repository: biomejs/biome

Length of output: 2011

🏁 Script executed:

rg -n 'typescript-sort-keys' crates/biome_cli/tests/commands/migrate_eslint.rs

Repository: biomejs/biome

Length of output: 39

🏁 Script executed:

rg -n 'typescript-sort-keys' crates/biome_cli/tests/snapshots/main_commands_migrate_eslint/

Repository: biomejs/biome

Length of output: 39

🏁 Script executed:

cat crates/biome_cli/tests/snapshots/main_commands_migrate_eslint/migrate_eslintrcjson.snap | head -50

Repository: biomejs/biome

Length of output: 1172

Add a migration snapshot test for typescript-sort-keys

Line 405 correctly wires the new source mapping, but there's no snapshot test confirming that typescript-sort-keys/<rule> resolves through this branch. Per coding guidelines, all Rust changes need appropriate tests—a migration snapshot covering this rule would catch regressions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@crates/biome_cli/src/execute/migrate/eslint_to_biome.rs` at line 405, Add a migration snapshot test that asserts the new mapping for "typescript-sort-keys" resolves to RuleSource::EslintTypescriptSortKeys; locate the existing migration snapshot test suite for the eslint_to_biome migration (look for tests that use the migration runner or snapshot helpers) and add a case that imports a rule path like "typescript-sort-keys/<rule>" and captures the resulting resolved mapping, then add the expected snapshot (or update the snapshot generator) so CI will verify that typescript-sort-keys routes through the new branch.

github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 8, 2026

coderabbitai Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread crates/biome_analyze/src/rule.rs

chore: missing rule source

0ac078d

Netail force-pushed the chore/missing-rule-source branch from 693e572 to 0ac078d Compare April 8, 2026 20:07

github-actions Bot added the A-CLI Area: CLI label Apr 8, 2026

coderabbitai Bot reviewed Apr 8, 2026

View reviewed changes

dyc3 approved these changes Apr 8, 2026

View reviewed changes

Netail merged commit 9993cdb into main Apr 8, 2026
29 checks passed

Netail deleted the chore/missing-rule-source branch April 8, 2026 20:33

This was referenced Apr 8, 2026

chore: extra rule sources #9872

Merged

chore: extra rule sources #9895

Merged

feat(js_analyze): implement useReactAsyncServerFunction #9909

Merged

This was referenced Apr 16, 2026

feat(lint): add noReactNativeRawText #10005

Merged

fix(migrate): enable multi-rule eslint mappings 🤖🤖🤖 #10027

Closed

coderabbitai Bot mentioned this pull request Apr 26, 2026

fix(10024): eslint generation #10118

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: missing rule source#9871

chore: missing rule source#9871
Netail merged 1 commit intomainfrom
chore/missing-rule-source

Netail commented Apr 8, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Netail commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Netail commented Apr 8, 2026 •

edited

Loading

changeset-bot Bot commented Apr 8, 2026 •

edited

Loading

coderabbitai Bot commented Apr 8, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 8, 2026 •

edited

Loading