fix(lint/js): improve diagnostics for noConstantCondition, useForOf, noRedeclare#9889
Merged
fix(lint/js): improve diagnostics for noConstantCondition, useForOf, noRedeclare#9889
noConstantCondition, useForOf, noRedeclare#9889Conversation
🦋 Changeset detectedLatest commit: c7d48f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
Merging this PR will not alter performance
Comparing Footnotes
|
47ef9f7 to
c89f59e
Compare
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (46)
📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughUpdated diagnostic messages for three linter rules in the analyzer: Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ematipico
approved these changes
Apr 10, 2026
Member
There was a problem hiding this comment.
A suggestion for the future, when you have these kinds of PRs. I found really useful having a commit for each change.
In this case, have a commit for each diagnostic you update (together with changeset and snapshot). Coding agents are good at that too.
c89f59e to
f44d1d9
Compare
…f`, `noRedeclare`
f44d1d9 to
c7d48f7
Compare
Contributor
Author
|
FYI @ematipico , updated the subsequent PRs in the stack with 1 commit per rule change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved the diagnostics for these rules. Split into separate PRs to hopefully make it a little more reviewable.
Generated by gpt 5.4, but I heavily guided the agent and reviewed all the new diagnostics myself, and did some manual refactors to reduce allocations.
Test Plan
snapshots
Docs