Skip to content

fix(lint/js): improve diagnostics for noSelfCompare, noThenProperty, noShorthandPropertyOverrides, noRootType, noAutofocus#9892

Merged
ematipico merged 5 commits intomainfrom
dyc3/better-rule-diagnostics-4
Apr 11, 2026
Merged

fix(lint/js): improve diagnostics for noSelfCompare, noThenProperty, noShorthandPropertyOverrides, noRootType, noAutofocus#9892
ematipico merged 5 commits intomainfrom
dyc3/better-rule-diagnostics-4

Conversation

@dyc3
Copy link
Copy Markdown
Contributor

@dyc3 dyc3 commented Apr 9, 2026 •
edited
Loading

Summary

Improved the diagnostics for these rules. Split into separate PRs to hopefully make it a little more reviewable.

Generated by gpt 5.4, but I heavily guided the agent and reviewed all the new diagnostics myself, and did some manual refactors to reduce allocations.

Test Plan

snapshots

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 9, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: a18a42b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dyc3 Graphite App
Copy link
Copy Markdown
Contributor Author

dyc3 commented Apr 9, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Apr 9, 2026
Merged
Merged
@github-actions github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS and super languages L-HTML Language: HTML and super languages labels Apr 9, 2026
@dyc3 dyc3 marked this pull request as ready for review April 9, 2026 18:59
@dyc3 dyc3 force-pushed the dyc3/better-rule-diagnostics-4 branch from 22e315a to 1c7c26b Compare April 10, 2026 18:08
@dyc3 dyc3 force-pushed the dyc3/better-rule-diagnostics-3 branch 2 times, most recently from e4d5b11 to f61619d Compare April 10, 2026 18:24
@dyc3 dyc3 force-pushed the dyc3/better-rule-diagnostics-4 branch from 1c7c26b to b61def3 Compare April 10, 2026 18:25
@dyc3 dyc3 changed the base branch from dyc3/better-rule-diagnostics-3 to graphite-base/9892 April 10, 2026 20:09
@dyc3 dyc3 force-pushed the dyc3/better-rule-diagnostics-4 branch from b61def3 to a18a42b Compare April 10, 2026 20:09
@dyc3 dyc3 force-pushed the graphite-base/9892 branch from f61619d to 7ae83f2 Compare April 10, 2026 20:09
@dyc3 dyc3 changed the base branch from graphite-base/9892 to main April 10, 2026 20:09
@ematipico ematipico merged commit e75d70e into main Apr 11, 2026
7 checks passed
@ematipico ematipico deleted the dyc3/better-rule-diagnostics-4 branch April 11, 2026 04:40
@github-actions github-actions Bot mentioned this pull request Apr 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-Linter Area: linter L-CSS Language: CSS and super languages L-HTML Language: HTML and super languages L-JavaScript Language: JavaScript and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dyc3 @ematipico