Conversation
|
A bug report and its bugfix in one pull request? You're a dream contributor, thank you! 💚 I've tested the changes and they do seem to solve the race condition. The
I'd also remove the |
|
Hi, thanks for the review! Those changes sound good, I'll apply them later today. |
|
I went ahead and pushed the changes above to your fork before merging 🚀 Thanks so much for testing and contributing this! |
|
Hey - sorry I didn't do the requested changes, work & life have a habit of being real busy suddenly |
|
You're fine! I know all about that struggle too, don't even sweat it 💚 |
Currently, I have a problem that when I edit metadata properties (in frontmatter, if that matters), then I don't get the right update to the icons. Its one change behind, probably a race condition of some kind or other.
This is a fix for that. It adds callbacks to both the vanilla meta store change event & the dataview one. I don't know if the dataview one is necessary, but another one doesn't hurt. I tested with and without dataview enabled & it worked both times so why not?
Also, I noticed that there are only very broad refresh functions, but is there a way to target only the modified files? That might help with performance