fix: update icon property on file modify & leaf open#121
Merged
gfxholo merged 2 commits intogfxholo:mainfrom Jun 22, 2025
Merged
fix: update icon property on file modify & leaf open#121gfxholo merged 2 commits intogfxholo:mainfrom
gfxholo merged 2 commits intogfxholo:mainfrom
Conversation
Owner
|
Hi nbsx, I just got time to test out these changes 💚 Thank you for the fix! Looks like this eliminates the property bug. this.registerEvent(this.app.vault.on('modify', tAbstractFile => {
...
...
// If we add a new property to a file, refresh property icons
this.editorIconManager?.refreshIcons();
}Since this extra code only affects the properties box, can you cut this line out of This also avoids a tiny merge conflict with #115, which is fixing some code at the same location in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for : #88
I tested many cases, and this work well.
Tell me if the commit name, or event "position" doesn't fit