Skip to content

Add a PasswordPoliciesBean to the FreeMarker context.#32625

Merged
ahus1 merged 1 commit intokeycloak:mainfrom
p2-inc:xgp/32553-password-policies
Sep 10, 2024
Merged

Add a PasswordPoliciesBean to the FreeMarker context.#32625
ahus1 merged 1 commit intokeycloak:mainfrom
p2-inc:xgp/32553-password-policies

Conversation

@xgp
Copy link
Copy Markdown
Contributor

@xgp xgp commented Sep 3, 2024

Closes #32553

  • Add services/src/main/java/org/keycloak/forms/login/freemarker/model/PasswordPoliciesBean.java
  • Update services/src/main/java/org/keycloak/forms/login/freemarker/FreeMarkerLoginFormsProvider.java createCommonAttributes method to add the bean with key passwordPolicies.

@xgp xgp requested a review from a team as a code owner September 3, 2024 20:21
@xgp xgp mentioned this pull request Sep 3, 2024
Closed
ahus1
ahus1 requested changes Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

GitHub reports "This branch has conflicts that must be resolved". Please rebase and resolve the conflicts. With conflicts, no check will run. Completed checks are the prerequisite for this to be merged.

I'll switch it to "draft" in the meantime. Switch it to "ready for review" once the conflicts have been resolved.

@ahus1 ahus1 marked this pull request as draft September 5, 2024 15:33
@xgp xgp force-pushed the xgp/32553-password-policies branch from d45799f to d6b8095 Compare September 5, 2024 16:47
@xgp xgp marked this pull request as ready for review September 5, 2024 16:47
@xgp
Copy link
Copy Markdown
Contributor Author

xgp commented Sep 5, 2024

@ahus1 Thanks. I rebased and fixed the conflicts.

@ahus1 ahus1 self-assigned this Sep 5, 2024
This was referenced Sep 5, 2024
Closed
Closed
Closed
@keycloak-github-bot
Copy link
Copy Markdown

keycloak-github-bot Bot commented Sep 5, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnPropertyTest#requiredActionRegistration

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=da140663-367d-4771-81e7-8dffc6429eaf&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessResidentKeyRegTest#residentKeyNotRequiredNoRK

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=78bf343f-f2c0-404c-b116-fa3e7501b376&session_state=a9d5c7b6-3f9c-4be2-b762-17a65424813d&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=e37da88b-32e0-4beb-8fe1-7ee81f83f9dc.a9d5c7b6-3f9c-4be2-b762-17a65424813d.3bf94a0b-ecde-47d9-be47-6697348228ac)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:253)
...

Report flaky test

org.keycloak.testsuite.forms.ResetPasswordTest#resetPasswordDisabledUser

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected LoginPasswordResetPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=a80025db-9407-4c09-a573-6f9d83ea762e&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.ResetPasswordTest#resetPasswordTwice

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected LoginPasswordResetPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=57453b07-e279-4701-b6ea-a447ba7db8d0&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.ResetPasswordTest#resetPasswordExpiredCodeShortPerActionMultipleTimeouts

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected LoginPasswordResetPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=fee16735-33d5-4f77-9956-35a19343426c&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown

@keycloak-github-bot keycloak-github-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ahus1 ahus1 merged commit 7988f02 into keycloak:main Sep 10, 2024
@garronej garronej mentioned this pull request Sep 12, 2024
Open
@garronej garronej mentioned this pull request Sep 19, 2024
Closed
@garronej garronej mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose Password Policies in FreeMarker Context for Login Themes

2 participants

@xgp @ahus1