Merged
Conversation
Collaborator
|
I'm not a huge fan of |
Collaborator
Author
|
Yah I'm not a fan of it either particularly, it was just the lazy option for sections since they shared so many imports between the different submodules. |
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of splitting #13.
This refactors the layout of the crate and cleans up imports a bit, but no functional changes.
linuxsubmodule that is reexported from the root so the outward API doesn't really change, it will just make adding additional target platforms cleanerLinuxPtraceDumpertoPtraceDumper, the naming was inherited from breakpad but doesn't make much sense since there is only one ptrace implementation, and even if a future one was added eg BSD, it would either be its own separate one, or else a specialization of the linux onecfg-ifto make them cleaner and easier to readOne breaking change I made was to move to the 2021 edition which is 5 months old at this point, but I can revert that if it's not wanted, the only change that this really enabled was to remove all of the
std::convert::TryIntoimports since that is part of the prelude in the 2021 edition.