Refactor to use minidump-common types#15
Merged
msirringhaus merged 4 commits intorust-minidump:mainfrom Mar 16, 2022
Merged
Conversation
Merged
Collaborator
msirringhaus
left a comment
There was a problem hiding this comment.
Got a few nitpicks ;-)
ce75ae5 to
6c2d7ce
Compare
Collaborator
|
Thank you very much! |
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds off #14.
This makes
minidump-commona regular dependency and removes all of the types declared inminidump_formatin favor of the types inminidump-common. This changes theMemoryWriterandMemoryArrayWriterstructs to instead usescrollfor writing the content into the buffer which (IMO) simplifies the internals, and changes the type restrictions. Some types inminidump-commonhave already had Pwrite derived for them, the remaining ones will be added in a future PR.